Skip to content

CLN: Window aggregation typing #40119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2021
Merged

CLN: Window aggregation typing #40119

merged 3 commits into from
Mar 1, 2021

Conversation

mroeschke
Copy link
Member

  • Use more const
  • Change some indexing variables to Py_ssize_t

@mroeschke mroeschke added Clean Window rolling, ewma, expanding labels Feb 28, 2021
@mroeschke mroeschke added this to the 1.3 milestone Feb 28, 2021
jbrockmendel
jbrockmendel reviewed Feb 28, 2021
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback merged commit 6c69a84 into pandas-dev:master Mar 1, 2021
@jreback
Copy link
Contributor

jreback commented Mar 1, 2021

thanks @mroeschke

@mroeschke mroeschke deleted the cln/window branch March 1, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Clean Window rolling, ewma, expanding
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @jreback @jbrockmendel